Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EUI to v99.2.0-borealis.0 #209690

Merged
merged 12 commits into from
Feb 13, 2025
Merged

Conversation

tkajtoch
Copy link
Member

@tkajtoch tkajtoch commented Feb 5, 2025

99.1.0-borealis.099.2.0-borealis.0

Questions? Please see our Kibana upgrade FAQ.


v99.2.0

  • Changed EuiFieldText styles to prioritize disabled styling over readonly. (#8271)
  • Added plugs and web glyphs to EuiIcon (#8285)
  • Update title on EuiColorPalettePickerPaletteProps to be optional (#8289)

Bug fixes

  • Fixed an issue with EuiDataGrid with auto row height resulting in a table of 0 height (#8251)
  • Fixed disabled behavior of EuiFieldText to prevent input changes. (#8271)

Borealis changes

  • [Visual Refresh] Provide hooks for color palette functions (#8284)
  • [Visual Refresh] Make Borealis default theme in EUI (#8288)

As you can probably tell, there are plenty of updated tests and snapshots this time around. They are the result of the following:

  1. We've updated the default theme in @elastic/eui v99.2.0 to Borealis, which led to kibana tests using renderWithTheme, mountWithTheme, and other utility functions that wrap the tested component in <EuiThemeProvider> to switch to the correct, new color values. With this change, all tests should now use Borealis, regardless of the testing framework or its configuration.
  2. Because of the default theme change in EUI, some class name hash fragments (e.g., css-wprskz-euiButtonIcon-xs-empty-primary) regenerated.

Most Borealis-related changes in this PR are test env only and have no impact on what users see when using Kibana.

@tkajtoch
Copy link
Member Author

tkajtoch commented Feb 9, 2025

@elasticmachine merge upstream

@tkajtoch tkajtoch marked this pull request as ready for review February 9, 2025 22:24
@tkajtoch tkajtoch requested review from a team as code owners February 9, 2025 22:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

@tkajtoch tkajtoch requested a review from a team as a code owner February 9, 2025 22:24
@tkajtoch tkajtoch requested a review from dhurley14 February 9, 2025 22:24
Copy link
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codeowner changes lgtm

@botelastic botelastic bot added Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team labels Feb 10, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

Copy link
Contributor

@consulthys consulthys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGT Stack Monitoring

Copy link
Contributor

@kapral18 kapral18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for explore

Copy link
Contributor

@Heenawter Heenawter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hex code changes LGTM:+1:

Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data Discovery changes LGTM

…e="number" fields work as expected with no duplicated characters
@tkajtoch
Copy link
Member Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
controls 474 460 -14
dashboard 730 716 -14
maps 1344 1330 -14
ml 2449 2435 -14
visTypeVega 328 314 -14
total -70

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
controls 495.3KB 441.8KB -53.5KB
dashboard 600.4KB 546.9KB -53.5KB
maps 3.1MB 3.0MB -53.5KB
ml 5.5MB 5.5MB -53.6KB
visTypeVega 1.9MB 1.9MB -53.5KB
total -267.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
controls 11.3KB 11.3KB +67.0B
dashboard 17.6KB 17.7KB +67.0B
kbnUiSharedDeps-npmDll 5.9MB 6.0MB +61.2KB
kbnUiSharedDeps-srcJs 3.6MB 3.6MB -57.5KB
maps 44.5KB 44.6KB +67.0B
ml 79.4KB 79.5KB +67.0B
visTypeVega 34.7KB 34.8KB +67.0B
total +4.1KB

History

cc @tkajtoch

@delanni delanni merged commit e5958a4 into elastic:main Feb 13, 2025
10 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 9.0

https://github.com/elastic/kibana/actions/runs/13304381418

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
9.0 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 209690

Questions ?

Please refer to the Backport tool documentation

JoseLuisGJ added a commit to JoseLuisGJ/kibana that referenced this pull request Feb 13, 2025
`99.1.0-borealis.0` ⏩ `99.2.0-borealis.0`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

---

## [`v99.2.0`](https://github.com/elastic/eui/releases/v99.2.0)

- Changed `EuiFieldText` styles to prioritize `disabled` styling over
`readonly`. ([elastic#8271](elastic/eui#8271))
- Added `plugs` and `web` glyphs to `EuiIcon`
([elastic#8285](elastic/eui#8285))
- Update `title` on `EuiColorPalettePickerPaletteProps` to be optional
([elastic#8289](elastic/eui#8289))

**Bug fixes**

- Fixed an issue with EuiDataGrid with auto row height resulting in a
table of 0 height ([elastic#8251](elastic/eui#8251))
- Fixed `disabled` behavior of `EuiFieldText` to prevent input changes.
([elastic#8271](elastic/eui#8271))

**Borealis changes**

- [Visual Refresh] Provide hooks for color palette functions
([elastic#8284](elastic/eui#8284))
- [Visual Refresh] Make Borealis default theme in EUI
([elastic#8288](elastic/eui#8288))

---

As you can probably tell, there are plenty of updated tests and
snapshots this time around. They are the result of the following:

1. We've updated the default theme in `@elastic/eui` v99.2.0 to
Borealis, which led to kibana tests using `renderWithTheme`,
`mountWithTheme`, and other utility functions that wrap the tested
component in `<EuiThemeProvider>` to switch to the correct, new color
values. With this change, all tests should now use Borealis, regardless
of the testing framework or its configuration.
2. Because of the default theme change in EUI, some class name hash
fragments (e.g., `css-`**`wprskz`**`-euiButtonIcon-xs-empty-primary`)
regenerated.

Most Borealis-related changes in this PR are test env only and have no
impact on what users see when using Kibana.

---------

Co-authored-by: Elastic Machine <[email protected]>

## Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials
- [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed
- [ ] The PR  description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...
@tkajtoch
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

tkajtoch added a commit to tkajtoch/kibana that referenced this pull request Feb 13, 2025
`99.1.0-borealis.0` ⏩ `99.2.0-borealis.0`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

---

## [`v99.2.0`](https://github.com/elastic/eui/releases/v99.2.0)

- Changed `EuiFieldText` styles to prioritize `disabled` styling over
`readonly`. ([elastic#8271](elastic/eui#8271))
- Added `plugs` and `web` glyphs to `EuiIcon`
([elastic#8285](elastic/eui#8285))
- Update `title` on `EuiColorPalettePickerPaletteProps` to be optional
([elastic#8289](elastic/eui#8289))

**Bug fixes**

- Fixed an issue with EuiDataGrid with auto row height resulting in a
table of 0 height ([elastic#8251](elastic/eui#8251))
- Fixed `disabled` behavior of `EuiFieldText` to prevent input changes.
([elastic#8271](elastic/eui#8271))

**Borealis changes**

- [Visual Refresh] Provide hooks for color palette functions
([elastic#8284](elastic/eui#8284))
- [Visual Refresh] Make Borealis default theme in EUI
([elastic#8288](elastic/eui#8288))

---

As you can probably tell, there are plenty of updated tests and
snapshots this time around. They are the result of the following:

1. We've updated the default theme in `@elastic/eui` v99.2.0 to
Borealis, which led to kibana tests using `renderWithTheme`,
`mountWithTheme`, and other utility functions that wrap the tested
component in `<EuiThemeProvider>` to switch to the correct, new color
values. With this change, all tests should now use Borealis, regardless
of the testing framework or its configuration.
2. Because of the default theme change in EUI, some class name hash
fragments (e.g., `css-`**`wprskz`**`-euiButtonIcon-xs-empty-primary`)
regenerated.

Most Borealis-related changes in this PR are test env only and have no
impact on what users see when using Kibana.

---------

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit e5958a4)

# Conflicts:
#	src/platform/packages/shared/kbn-unified-data-table/src/components/compare_documents/hooks/__snapshots__/use_comparison_css.test.ts.snap
#	x-pack/solutions/security/packages/kbn-securitysolution-exception-list-components/src/exception_item_card/conditions/entry_content/__snapshots__/entry_content.test.tsx.snap
#	x-pack/solutions/security/plugins/security_solution/public/explore/network/components/embeddables/__mocks__/mock.ts
tkajtoch added a commit that referenced this pull request Feb 14, 2025
# Backport

This will backport the following commits from `main` to `9.0`:
- [Upgrade EUI to v99.2.0-borealis.0
(#209690)](#209690)

<!--- Backport version: 9.6.4 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Tomasz
Kajtoch","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-13T09:20:46Z","message":"Upgrade
EUI to v99.2.0-borealis.0 (#209690)\n\n`99.1.0-borealis.0` ⏩
`99.2.0-borealis.0`\n\n[Questions? Please see our Kibana
upgrade\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)\n\n---\n\n##
[`v99.2.0`](https://github.com/elastic/eui/releases/v99.2.0)\n\n-
Changed `EuiFieldText` styles to prioritize `disabled` styling
over\n`readonly`. ([#8271](https://github.com/elastic/eui/pull/8271))\n-
Added `plugs` and `web` glyphs to
`EuiIcon`\n([#8285](https://github.com/elastic/eui/pull/8285))\n- Update
`title` on `EuiColorPalettePickerPaletteProps` to be
optional\n([#8289](https://github.com/elastic/eui/pull/8289))\n\n**Bug
fixes**\n\n- Fixed an issue with EuiDataGrid with auto row height
resulting in a\ntable of 0 height
([#8251](https://github.com/elastic/eui/pull/8251))\n- Fixed `disabled`
behavior of `EuiFieldText` to prevent input
changes.\n([#8271](https://github.com/elastic/eui/pull/8271))\n\n**Borealis
changes**\n\n- [Visual Refresh] Provide hooks for color palette
functions\n([#8284](https://github.com/elastic/eui/pull/8284))\n-
[Visual Refresh] Make Borealis default theme in
EUI\n([#8288](https://github.com/elastic/eui/pull/8288))\n\n---\n\nAs
you can probably tell, there are plenty of updated tests and\nsnapshots
this time around. They are the result of the following:\n\n1. We've
updated the default theme in `@elastic/eui` v99.2.0 to\nBorealis, which
led to kibana tests using `renderWithTheme`,\n`mountWithTheme`, and
other utility functions that wrap the tested\ncomponent in
`<EuiThemeProvider>` to switch to the correct, new color\nvalues. With
this change, all tests should now use Borealis, regardless\nof the
testing framework or its configuration.\n2. Because of the default theme
change in EUI, some class name hash\nfragments (e.g.,
`css-`**`wprskz`**`-euiButtonIcon-xs-empty-primary`)\nregenerated.\n\nMost
Borealis-related changes in this PR are test env only and have
no\nimpact on what users see when using
Kibana.\n\n---------\n\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"e5958a47f302c69871310903caeebc69257f886a","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","EUI","v9.0.0","Team:obs-ux-infra_services","Team:obs-ux-management","backport:version","v9.1.0"],"title":"Upgrade
EUI to
v99.2.0-borealis.0","number":209690,"url":"https://github.com/elastic/kibana/pull/209690","mergeCommit":{"message":"Upgrade
EUI to v99.2.0-borealis.0 (#209690)\n\n`99.1.0-borealis.0` ⏩
`99.2.0-borealis.0`\n\n[Questions? Please see our Kibana
upgrade\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)\n\n---\n\n##
[`v99.2.0`](https://github.com/elastic/eui/releases/v99.2.0)\n\n-
Changed `EuiFieldText` styles to prioritize `disabled` styling
over\n`readonly`. ([#8271](https://github.com/elastic/eui/pull/8271))\n-
Added `plugs` and `web` glyphs to
`EuiIcon`\n([#8285](https://github.com/elastic/eui/pull/8285))\n- Update
`title` on `EuiColorPalettePickerPaletteProps` to be
optional\n([#8289](https://github.com/elastic/eui/pull/8289))\n\n**Bug
fixes**\n\n- Fixed an issue with EuiDataGrid with auto row height
resulting in a\ntable of 0 height
([#8251](https://github.com/elastic/eui/pull/8251))\n- Fixed `disabled`
behavior of `EuiFieldText` to prevent input
changes.\n([#8271](https://github.com/elastic/eui/pull/8271))\n\n**Borealis
changes**\n\n- [Visual Refresh] Provide hooks for color palette
functions\n([#8284](https://github.com/elastic/eui/pull/8284))\n-
[Visual Refresh] Make Borealis default theme in
EUI\n([#8288](https://github.com/elastic/eui/pull/8288))\n\n---\n\nAs
you can probably tell, there are plenty of updated tests and\nsnapshots
this time around. They are the result of the following:\n\n1. We've
updated the default theme in `@elastic/eui` v99.2.0 to\nBorealis, which
led to kibana tests using `renderWithTheme`,\n`mountWithTheme`, and
other utility functions that wrap the tested\ncomponent in
`<EuiThemeProvider>` to switch to the correct, new color\nvalues. With
this change, all tests should now use Borealis, regardless\nof the
testing framework or its configuration.\n2. Because of the default theme
change in EUI, some class name hash\nfragments (e.g.,
`css-`**`wprskz`**`-euiButtonIcon-xs-empty-primary`)\nregenerated.\n\nMost
Borealis-related changes in this PR are test env only and have
no\nimpact on what users see when using
Kibana.\n\n---------\n\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"e5958a47f302c69871310903caeebc69257f886a"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209690","number":209690,"mergeCommit":{"message":"Upgrade
EUI to v99.2.0-borealis.0 (#209690)\n\n`99.1.0-borealis.0` ⏩
`99.2.0-borealis.0`\n\n[Questions? Please see our Kibana
upgrade\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)\n\n---\n\n##
[`v99.2.0`](https://github.com/elastic/eui/releases/v99.2.0)\n\n-
Changed `EuiFieldText` styles to prioritize `disabled` styling
over\n`readonly`. ([#8271](https://github.com/elastic/eui/pull/8271))\n-
Added `plugs` and `web` glyphs to
`EuiIcon`\n([#8285](https://github.com/elastic/eui/pull/8285))\n- Update
`title` on `EuiColorPalettePickerPaletteProps` to be
optional\n([#8289](https://github.com/elastic/eui/pull/8289))\n\n**Bug
fixes**\n\n- Fixed an issue with EuiDataGrid with auto row height
resulting in a\ntable of 0 height
([#8251](https://github.com/elastic/eui/pull/8251))\n- Fixed `disabled`
behavior of `EuiFieldText` to prevent input
changes.\n([#8271](https://github.com/elastic/eui/pull/8271))\n\n**Borealis
changes**\n\n- [Visual Refresh] Provide hooks for color palette
functions\n([#8284](https://github.com/elastic/eui/pull/8284))\n-
[Visual Refresh] Make Borealis default theme in
EUI\n([#8288](https://github.com/elastic/eui/pull/8288))\n\n---\n\nAs
you can probably tell, there are plenty of updated tests and\nsnapshots
this time around. They are the result of the following:\n\n1. We've
updated the default theme in `@elastic/eui` v99.2.0 to\nBorealis, which
led to kibana tests using `renderWithTheme`,\n`mountWithTheme`, and
other utility functions that wrap the tested\ncomponent in
`<EuiThemeProvider>` to switch to the correct, new color\nvalues. With
this change, all tests should now use Borealis, regardless\nof the
testing framework or its configuration.\n2. Because of the default theme
change in EUI, some class name hash\nfragments (e.g.,
`css-`**`wprskz`**`-euiButtonIcon-xs-empty-primary`)\nregenerated.\n\nMost
Borealis-related changes in this PR are test env only and have
no\nimpact on what users see when using
Kibana.\n\n---------\n\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"e5958a47f302c69871310903caeebc69257f886a"}}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels EUI release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team v9.0.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.